Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(X (Formerly Twitter) Node): Rename Twitter to X (keep Twitter alias) #7179

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Sep 14, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to do a docs change in the future as well

@cypress
Copy link

cypress bot commented Sep 14, 2023

3 flaky tests on run #2178 ↗︎

0 241 0 0 Flakiness 3

Details:

🌳 node-741-rename-twitter-to-x 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ ...
Project: n8n Commit: b2c1d70d69
Status: Passed Duration: 07:56 💡
Started: Sep 14, 2023 3:42 PM Ended: Sep 14, 2023 3:50 PM
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Output Screenshots Video
Flakiness  6-code-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
... > generate code button should have correct state & tooltips Output Screenshots Video
Flakiness  18-user-management.cy.ts • 1 flaky test

View Output Video

Test Artifacts
User Management > should delete user and their data Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.01% ⚠️

Comparison is base (54bf66d) 32.44% compared to head (b2c1d70) 32.44%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7179      +/-   ##
==========================================
- Coverage   32.44%   32.44%   -0.01%     
==========================================
  Files        3279     3279              
  Lines      198092   198092              
  Branches    21667    21664       -3     
==========================================
- Hits        64278    64276       -2     
- Misses     132754   132756       +2     
  Partials     1060     1060              
Files Changed Coverage Δ
...s-base/credentials/TwitterOAuth1Api.credentials.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/Twitter/Twitter.node.ts 100.00% <ø> (ø)
...s-base/credentials/TwitterOAuth2Api.credentials.ts 100.00% <100.00%> (ø)
...ages/nodes-base/nodes/Twitter/V2/TwitterV2.node.ts 30.43% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 14, 2023
@elsmr elsmr changed the title fix(X Node): Rename Twitter to X (keep Twitter alias) fix(X (Formerly Twitter) Node): Rename Twitter to X (keep Twitter alias) Sep 15, 2023
@elsmr elsmr merged commit d317e09 into master Sep 15, 2023
18 of 19 checks passed
@elsmr elsmr deleted the node-741-rename-twitter-to-x branch September 15, 2023 13:04
MiloradFilipovic added a commit that referenced this pull request Sep 18, 2023
* master:
  feat(core): Add command to trigger license refresh on workers (#7184)
  fix(X (Formerly Twitter) Node): Rename Twitter to X (keep Twitter alias) (#7179)
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
krynble added a commit that referenced this pull request Sep 20, 2023
# [1.8.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.8.0)
(2023-09-20)


### Bug Fixes

* **core:** Make parsing of content-type and content-disposition headers
more flexible ([#7217](#7217))
([d41546b](d41546b)),
closes [#7149](#7149)
* **core:** Resolve domains to IPv4 first
([#7206](#7206))
([e9ce531](e9ce531))
* **editor:** Add ssh key type selection to source control settings when
regenerating key ([#7172](#7172))
([54bf66d](54bf66d))
* **editor:** No need to add click emitting click events, VUE delegates
the handler to the root element of the component
([#7182](#7182))
([3c055e4](3c055e4))
* **editor:** Prevent duplicate creation of credential for OAuth2
([#7163](#7163))
([07a6417](07a6417))
* **editor:** Testing flaky resource mapper feature in e2e tests
([#7165](#7165))
([aaf87c3](aaf87c3))
* **HTML Node:** Add pairedItem support for 'Convert to HTML Table'
operation ([#7196](#7196))
([6bc477b](6bc477b))
* **HTTP Request Node:** Decrease default timeout to 5min
([#7177](#7177))
([321780d](321780d))
* **seven Node:** Rename sms77 to seven, fix credentials test
([#7180](#7180))
([cf776b8](cf776b8))
* **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter
alias) ([#7179](#7179))
([d317e09](d317e09))


### Features

* **core:** Add command to trigger license refresh on workers
([#7184](#7184))
([9f797b9](9f797b9))
* **core:** Add rsa option to ssh key generation
([#7154](#7154))
([fdac2c8](fdac2c8))
* **Linear Node:** Add support for OAuth2
([#7201](#7201))
([12a3168](12a3168))
* **Microsoft Outlook Node:** Node overhaul
([#4449](#4449))
([556a613](556a613))
* **Set Node:** Overhaul
([#6348](#6348))
([3a47455](3a47455))

Co-authored-by: krynble <[email protected]>
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants